MIM-869 Handle APIv2 + APIv3 requests (phoenix controller) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rslota
reviewed
May 14, 2020
| @@ -5,7 +5,7 @@ defmodule MongoosePush.API.V2.ResponseEncoder do | |||
| @behaviour MongoosePush.API | |||
| alias MongoosePush.Service | |||
|
|
|||
| @spec to_status(:ok | {:error, Service.error() | {:error, MongoosePush.error()}}) :: | |||
| @spec to_status(:ok | {:error, Service.error()} | {:error, MongoosePush.error()}) :: | |||
| @spec decode(%Deep.MixedNotification{}) :: MongoosePush.request() | ||
| def decode(schema) do | ||
| %{ | ||
| service: String.to_atom(schema.service), |
There was a problem hiding this comment.
Don't we have a helper that does this better? Even if not, then let's use to_existing_atom at least.
There was a problem hiding this comment.
I implemented one, following the way @michalwski already suggested here.
| @spec decode(%Deep.SilentNotification{}) :: MongoosePush.request() | ||
| def decode(schema) do | ||
| %{ | ||
| service: String.to_atom(schema.service), |
There was a problem hiding this comment.
Don't we have a helper that does this better? Even if not, then let's use to_existing_atom at least.
rslota
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the intuitive continuation of MIM-868 story, with the main difference that here I cover handling of the requests specified by APIv2 & APIv3.
In the home stretch it also turned out that I needed to - kind of - rollback to previous schemas design, reintroducing
MixedNotificationdefinition. Source rationale is thatOpenApiSpexframework is not doing well when it finds incoming request matching more than one schema definition.