refactor api_v*_notification_controller tests #173
Conversation
| @dropped_fields ["service", "body"] | ||
| for dropped <- @dropped_fields do | ||
| test "Request.SendNotification.FlatNotification schema without required #{dropped} field", %{ | ||
| conn: conn | ||
| } do | ||
| body = | ||
| ControllersHelper.flat_request() | ||
| |> Map.drop([unquote(dropped)]) | ||
| |> Jason.encode!() |
There was a problem hiding this comment.
Niiiice, less duplication 😄
Just one question, maybe I can learn something about elixir here. Why's that unquote in unquote(dropped) necessary?
There was a problem hiding this comment.
It's macros magic 😁 We're reading the values from so-called module attribute declared with @, and because we're kinda injecting it in test body, it needs to be evaluated (back to the string like I wrote the code) and inserted in the place of unquote(dropped). To understand more what this macro stuff is about, you can head to here, here, or this answer on elixir forum almost exactly covering this specific case.
| body = | ||
| ControllersHelper.flat_request() | ||
| |> Map.put("badge", "seven") | ||
| |> Jason.encode!() | ||
|
|
||
| conn = post(conn, "/v1/notification/666", body) |
| Jason.encode!(%{ControllersHelper.silent_request() | "time_to_live" => "infinity"}) | ||
| ) | ||
| body = | ||
| ControllersHelper.alert_request() |
There was a problem hiding this comment.
Guys, maybe this year' golden shovel award goes to me, but shouldn't it be silent_request? 🙄
Here I introduce some quick refactor of the test suites developed while incorporating
OpenApiSpexto the project, originally proposed by @aleklisi in #168. Since these changes has been interfering with the ones from #172, decreasing their readability, I decided to extract them to the separate PR.