Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete :mock and :meck dependencies #181

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Conversation

kmakiela
Copy link
Contributor

This PR removes :meck and :mock from the dependency list.
Both :meck and :mock are not needed anymore. All the tests that used these libraries were already rewritten (most of them use :mox now).

@NelsonVides
Copy link
Contributor

So cool it would be so simple to get rid of Mock 😄
But what about the mix.lock file, doesn't that one need to be cleaned out as well?

@janciesla8818 janciesla8818 requested a review from leszke June 26, 2020 08:55
@michalwski
Copy link
Contributor

@kmakiela I second @NelsonVides questions. Looks like mix.lock needs an update.

@kmakiela
Copy link
Contributor Author

Further investigation shows that :meck is still loaded as a Sparrow dependency (and Sparrow only) so this PR is temporarily blocked by:
esl/sparrow#47

@NelsonVides
Copy link
Contributor

@kmakiela esl/sparrow#47 was merged, we can move forward with this one 🙂

Copy link
Contributor

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🎉

@NelsonVides NelsonVides merged commit 78e82d9 into master Jun 30, 2020
@NelsonVides NelsonVides deleted the km/discard_mock branch June 30, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants