Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #203

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Upgrade dependencies #203

merged 5 commits into from
Sep 20, 2022

Conversation

kamilwaz
Copy link
Contributor

Updates Phoenix and other dependencies to latest versions. Alongside, Erlang was updated to 25.0 and Elixir to 1.13.

Kamil Waz added 3 commits September 13, 2022 15:36
Update Phoenix to 1.5
2a0667d 
Alongside, Erlang was updated to 24.3 and Elixir to 1.12.
Update Phoenix to 1.6
889e6b3 
Alongside, Erlang was updated to 25.0 and Elixir to 1.13.
Update dependencies
91d5d9a
@kamilwaz kamilwaz force-pushed the upgrade branch 20 times, most recently from 228d4b6 to db13b5e Compare September 15, 2022 10:05
@kamilwaz
Copy link
Contributor Author

Erlang cannot be upgraded to 25.x because distillery doesn't support this version yet. The change that blocks it: erlang/otp@5ea1d07.

@kamilwaz kamilwaz force-pushed the upgrade branch 4 times, most recently from 651eca8 to 00cbc4d Compare September 15, 2022 13:07
@kamilwaz kamilwaz marked this pull request as ready for review September 15, 2022 14:09
michalwski
michalwski reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had some comments/questions.

Dockerfile Outdated
@@ -23,7 +30,7 @@ RUN mix do certs.dev, distillery.release
RUN tar -czf mongoose_push.tar.gz -C _build/prod/rel/mongoose_push .


FROM debian:stretch-slim
FROM ubuntu:20.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final docker image inside which the built MongoosePush will run. We used debian:stretch-slim to make the final image as small as possible. Do we have something similar to ubuntu:20.04 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, not. I changed the final image back to debian.

test/unit/test_helper.exs
@@ -1,2 +1,4 @@
Code.put_compiler_option(:warnings_as_errors, true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

michalwski
michalwski approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, approving it. Go ahead and merge.

@michalwski
Copy link
Contributor

Erlang cannot be upgraded to 25.x because distillery doesn't support this version yet. The change that blocks it: erlang/otp@5ea1d07.

In fact, we could move away from distillery to the built-in release mechanism. The built-in got improved in Elixir after this project was actively developed so probably there's no reason to use the distillery anymore.

@kamilwaz kamilwaz merged commit 301a62d into master Sep 20, 2022
@kamilwaz kamilwaz deleted the upgrade branch September 21, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalwski michalwski michalwski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilwaz @michalwski