Pause on all nodes during join #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter_unpause testcase
Add send_check_servers_is_called_before_last_server_got_dump case Delay check_server call
Pause from all nodes during the join To avoid unpausing some nodes when they loose connection with the coordinator (but coordinator is still alive)
Aggressive pausing would ensure that check_server is only sent after cets_join sent all the send_dump messages
Reformat update_node_down_history
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 98.26% 98.32% +0.06%
==========================================
Files 10 10
Lines 750 778 +28
==========================================
+ Hits 737 765 +28
Misses 13 13 ☔ View full report in Codecov by Sentry. |
arcusfelis
added a commit
to esl/MongooseIM
that referenced
this pull request
Dec 23, 2023
arcusfelis
force-pushed
the
delayed-check-servers
branch
from
bf92967
to
af69df8
Compare
arcusfelis
added a commit
to esl/MongooseIM
that referenced
this pull request
Dec 24, 2023
chrzaszcz
reviewed
Jan 3, 2024
|
After a discussion with @arcusfelis I understand the current solution, and it seems good enough for now. We just need to address the remaining comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid race conditions we have to pause on all nodes.
The issue:
I've tried to show the errors in tests.
Solution:
Adresses MIM-2137