Fix escaping bug #14
Merged
Fix escaping bug #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we try MongooseIM and/or escalus with this exml version before merge? |
|
Yes, I am going to do it in two steps:
|
added 3 commits
September 16, 2015 14:10
If we keep the types inside modules(not in hrl) we can shorten their names, instead of exml_stream:xmlstreamstart() we can write exml_stream:start(), exml:cdata() etc. btw I renamed stream end to stream stop, reasoning it should be either start/stop or begin end.
ppikula
force-pushed
the
fix-escaping-bug
branch
from
503aff1
to
cbd7f92
Compare
|
This branch was battle(load) tested during previous 2 weeks, both in Mongoose and tests. Summary:
|
michalwski
added a commit
that referenced
this pull request
Oct 9, 2015
* xml_size function was added - calculates size of xmlel record * we are escaping every attribute & cdata - this allow a programmer to not think about it an possibly forget about doing this in crucial places. * switched binary allocator: `enif_alloc_binary` -> `enif_make_new_binary`, because the first one **always** allocates refcounted binary, that leads to increased memory usage in case of small binaries. * after changing the allocators buffer overflow revealed. It was one byte and was able to cause seg fault of the whole VM see: df539c8 * I changed types, IMO they are more readable and consistent. * Improved coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #11 for details