Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subelement_with_name_and_ns bug #38 #67

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix subelement_with_name_and_ns bug #38 #67

merged 1 commit into from
Nov 13, 2023

Conversation

NelsonVides
Copy link

If we have list of elements:

  • [#xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns">>}]}, #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}] and call exml_query:subelement_with_name_and_ns/3 with <<"a">> and <<"ns2">>, we will get:
  • currently - undefined
  • expected - #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]}

Fixes #38

@NelsonVides
Fix subelement_with_name_and_ns bug
f86f554 
If we have list of elements:
- [#xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns">>}]}, #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]
and call exml_query:subelement_with_name_and_ns/3 with <<"a">> and <<"ns2">>, we will get:
- currently - undefined
- expected - #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]}
chrzaszcz
chrzaszcz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@chrzaszcz chrzaszcz merged commit 9814aa2 into master Nov 13, 2023
5 checks passed
@NelsonVides NelsonVides deleted the bugfix/subelement_with_name_and_ns branch November 13, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exml_query:subelement_with_name_and_ns
2 participants
@NelsonVides @chrzaszcz