Crypto modern api #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
===========================================
- Coverage 89.94% 63.31% -26.63%
===========================================
Files 2 2
Lines 179 199 +20
Branches 13 44 +31
===========================================
- Hits 161 126 -35
- Misses 18 73 +55 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
647bfa6 to
ae22bea
Compare
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
ae22bea to
713e745
Compare
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
9e268ec to
169e9cf
Compare
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
169e9cf to
f678d1e
Compare
DenysGonchar
requested changes
Feb 18, 2025
chrzaszcz
reviewed
Feb 18, 2025
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
f678d1e to
d7957cb
Compare
NelsonVides
force-pushed
the
crypto_modern_api
branch
2 times, most recently
from
71c37f3 to
a144c64
Compare
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
a144c64 to
b6c4536
Compare
|
There's some progress, now the failure is well handled and doesn't segfault nor aborts. But the failure's still there 🥲 |
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
b6c4536 to
e434a05
Compare
chrzaszcz
reviewed
Feb 19, 2025
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
e434a05 to
cf388f1
Compare
This is the main rework. I initially wrote the standard functions for SHA1, and only later refactored to extract all SHA1 specifics into macro parameters, so that all other algorithms could be generated by the macro. It follows the same idea that the previous code, however it is not a step-by-step refactoring but a rewrite from scratch.
There was an issue in MacOS where in 15.x the dynamic linker would give preference to the system's cached `libboringssl.dylib`, instead of the OpenSSL's one put in the path. For the dynamic linker to resolve the right library correctly, the static linker would need to add strict resolution rules by being provided more strict flags.
NelsonVides
force-pushed
the
crypto_modern_api
branch
from
cf388f1 to
5e1e46d
Compare
chrzaszcz
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #14, and also implements the SHA3 family of algorithms, which turned out to be a low hanging fruit after the API migration.