fix: prefer-node-protocol: not first target (#204)

eslint-community · Mar 20, 2024 · caab777 · caab777
1 parent 8327d11
commit caab777
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/prefer-node-protocol.js b/lib/rules/prefer-node-protocol.js
@@ -124,7 +124,7 @@ module.exports = {
                             !isBuiltinModule(value) ||
                             !isBuiltinModule(`node:${value}`)
                         ) {
-                            return
+                            continue
                         }
 
                         context.report({

diff --git a/tests/lib/rules/prefer-node-protocol.js b/tests/lib/rules/prefer-node-protocol.js
@@ -191,6 +191,17 @@ new RuleTester({
             output: "const fs = require('node:fs/promises')",
             errors: ["Prefer `node:fs/promises` over `fs/promises`."],
         },
+        {
+            code: `
+                const express = require('express');
+                const fs = require('fs/promises');
+            `,
+            output: `
+                const express = require('express');
+                const fs = require('node:fs/promises');
+            `,
+            errors: ["Prefer `node:fs/promises` over `fs/promises`."],
+        },
 
         // check enabling by supported Node.js versions
         {