-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node:
prefix not working with some rules
#81
Comments
just saw it also, any updates on it? I guess fixing it should be easy |
I think #87 could fix this too. |
@piranna great! But it seems the referenced PR does not add any unit tests for that it works, which is probably important to not break it in the future. |
Fair enough, but it just import some third party module, like dependencies... |
const url1 = require('url');
const url2 = require('node:url');
url1.parse('http://example.com');
url2.parse('http://example.com'); An |
After adding `node:`, this causes `Unused eslint-disable directive` errors due to eslint-community/eslint-plugin-n#81 Remove the inline disable until n/no-deprecated-api works with node: protocol imports. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
I tested this using
"n/prefer-promises/fs": "error"
and it gave no error:The rules
prefer-promises
does not seem to be able to handle using thenode:
prefix. Maybe this is true for several more rules?The text was updated successfully, but these errors were encountered: