feat: eslint v9.0.0 compatibility (fixes #143)

[aladdin-add]

refs: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/

fixes #143

[scagood]

suggestion (non-blocking): It may be worth considering expiring-todo-comments here as that is a lot of TODOs we'll need to deal with in the future!

[aladdin-add]

It may be worth considering expiring-todo-comments here as that is a lot of TODOs we'll need to deal with in the future!

If that's the case, I'd prefer to use an issue for tracking the todos - it's not a good DX if someone makes an unrelated change and the build suddenly fails.

[scagood]

If that's the case, I'd prefer to use an issue for tracking the todos - it's not a good DX if someone makes an unrelated change and the build suddenly fails.

mmm, that's fair, maybe a gh action to pull all todos into a comment would be nice.

Do ignore this for now, we can solve it later as you say!

[scagood]

For reference, in #139 I moved this wholesale to lib/util/get-tsconfig.js:32

[scagood]

I can still see two more places, here are the traces:

(node:17752) DeprecationWarning: "no-unsupported-features/es-syntax" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
  at dispatch (/home/scagood/github/eslint-plugin-n/lib/util/merge-visitors-in-place.js:16:136)

(node:17752) DeprecationWarning: "prefer-global/buffer" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
  at Verifier.verifyToPreferModules (/home/scagood/github/eslint-plugin-n/lib/util/check-prefer-global.js:18:178)
  at checkForPreferGlobal (/home/scagood/github/eslint-plugin-n/lib/util/check-prefer-global.js:18:524)
  at Program:exit (/home/scagood/github/eslint-plugin-n/lib/rules/prefer-global/buffer.js:5:1047)

[aladdin-add]

thanks for checking this, will investigate it later. :)

[bmish]

You need to move fixes #143 to the PR description for linking to work properly.

[aladdin-add]

it's ready for reviewing now. 🎉

[aladdin-add]

I'm going to merge it as of now - we can do another PR if you have any suggestions:). cc @scagood

[scagood]

Sorry, I have been away 👀

I have no additional comments, this looks good to me 😀