-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shebang): Add options to ignore unpublished files #172
Conversation
8d0442b
to
125bdfe
Compare
Dang it! I could try to ignore the setting on windows 🤔 |
This is ignoring the shebang if the files are in .npmignore, isn't It? |
It does not, I can do that though! |
I think at least in Linux and macOS would solve the most of use cases. |
Yeah, that makes sense. I like it! |
I think that is a lot cleaner and quicker too 🤔 |
Yeah, maybe there would be some other corner cases, but that would be a huge filter anyway. |
the code LGTM, can we put it behind an option? |
I intend on adding both options this weekend!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is a possible solution to #119 suggested by @piranna