Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude for valid-params rule #127

Closed
alexilyaev opened this issue May 2, 2018 · 1 comment · Fixed by #515
Closed

Add exclude for valid-params rule #127

alexilyaev opened this issue May 2, 2018 · 1 comment · Fixed by #515
Labels
enhancement

Comments

@alexilyaev
Copy link

alexilyaev commented May 2, 2018 •
edited
Loading

Description

When using Bluebird, there are cases that deviate from the standard usage of promise functions.
One that I found is Bluebird's .catch can receive 2 arguments.
See http://bluebirdjs.com/docs/api/catch.html#filtered-catch

So, I think we should have an exclude option to set which functions not to check.
@macklinu
Copy link
Contributor

I'd be open to a PR for this!

brettz9 added a commit to brettz9/eslint-plugin-promise that referenced this issue Jul 25, 2024
@brettz9
feat(valid-params): add exclude option; fixes eslint-community#127
7255074
@brettz9 brettz9 mentioned this issue Jul 25, 2024
Merged
1 task
brettz9 added a commit to brettz9/eslint-plugin-promise that referenced this issue Jul 29, 2024
@brettz9
feat(valid-params): add exclude option; fixes eslint-community#127
0eb37d9
brettz9 added a commit to brettz9/eslint-plugin-promise that referenced this issue Jul 30, 2024
@brettz9
feat(valid-params): add exclude option; fixes eslint-community#127
20f34a2
brettz9 added a commit to brettz9/eslint-plugin-promise that referenced this issue Oct 16, 2024
@brettz9
feat(valid-params): add exclude option; fixes eslint-community#127
cd505bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(valid-params): add exclude option brettz9/eslint-plugin-promise
3 participants
@brettz9 @alexilyaev @macklinu