-
-
Notifications
You must be signed in to change notification settings - Fork 244
discussion: what sort of minimum versions we need to support? #543
Comments
@jamiebuilds’s suggestion of |
We can consider creating a "modern build" like |
at the very least, we still need to support IE11, for windows 7 users -- Edge requires windows 10. But I'd like to see someone share the GA data. |
However, the ESLint website itself doesn't use Babel currently. That means, we may not need to change the JS about the website. (It's still supporting old browsers.) |
Here's top 40 browser stats for one week (Feb 12 - 18):
P.S. I wish Google Analytics would finally add ability to get browsers by major version... This jumping through Excel hoops thing takes waaay too long. |
I think we can drop IE <= 10, but do we want to support IE 11 (given its ~0.54% share)? |
Can we create two builds? One is for old browsers and another is for evergreen browsers. |
What would be the point of creating two builds? I'm fine with dropping IE10. But I would keep IE11, as it's not upgradable. |
For those who use evergreen browsers, they can leverage the optimization of the new browsers and fetch smaller bundle size (less Babel transpilation). |
I'm not a big fan of this -- as Chrome takes the largest body, it seems not worthy the complexity IMHO. |
seems we got a problem on IE11. see eslint/eslint#11504 (comment) I'm afraid we have to drop support it. thoughts? |
I'm a bit confused by this, because as far as I know we're not actually transpiling anything. Is the purpose of this discussion to decide on a policy so that going forward we can potentially start using features from ES2015 and beyond? Some relevant discussion regarding adding a build step: #536 |
I think @g-plane means eslint.js/espree.js in the demo page -- they were built in eslint repo. |
It would be nice to have some data - who here has access to the Google Analytics account? |
I have access to google analytics. But creating those reports based on browser version is a major pain, since GA doesn't support it naively, and you have to do a huge number of transformations in Excel. What information are you looking for, specifically? |
I was wondering if it would be useful to get a breakdown of what percentage of visits are from various browsers so that we can let that inform our decision here. |
You mean by browser or by browser version (like the table above)? By browser, it's easy, GA has a report that I can generate without any problem. By browser version takes a lot of work, since GA doesn't support that type of report naively and you have to correlate multiple reports by hands in Excel. |
@ilyavolodin Maybe we could start with the breakdown of browsers? i.e. if we see that IE is <2% of traffic maybe we can drop support. I think the tricky one here is Safari, since it doesn't automatically update and is tied to macOS versions. |
IE 11 is ~0.54%, and I didn't see IE<11 in top40. see #543 (comment) should this be discussed in a TSC meeting? |
Demo can't be run on IE now: eslint/eslint#11504 . |
Oh, really sorry @ilyavolodin, I don’t know how I missed the breakdown above. |
Well, that breakdown is pretty old. But it took me over an hour and a half to build it, that's why I'm hesitant to commit to redoing it again:-) But here's breakdown for top 10 browsers (not versions) for the last month:
Specifically, IE11 is the highest used Microsoft browser on our site with 1,824(0.72%). |
just added it to tsc agenda. please note: demo can't be run on IE now (as @g-plane mentioned), and seems there is no easy ways to fix it. |
This was discussed at this week's TSC meeting. The TSC resolved that the website will support IE 11, but that we won't support IE 11 in the demo due to it being such a small percentage of visits and doesn't seem like a trivial amount of work. |
Closing due to age. |
refs:eslint/eslint#11398 (comment)
a bit related to #537
The text was updated successfully, but these errors were encountered: