Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move accordion to one level #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harish-sethuraman
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

  • for first level of accordion alone use accordion
  • for anything more than first level its a static open one

Related Issues

fixes #71

Is there anything you'd like reviewers to focus on?

  • N/A

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit ec3211e
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/671f8379bcd242000859a60e
😎 Deploy Preview https://deploy-preview-72--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented Oct 28, 2024

I thought the change was only going to be for properties that contained a single item, but it looks like this change also applies to arrays, where I don't think we should make this change. In arrays, it's very helpful to be able to collapse items.

Screenshot 2024-10-28 at 09-35-35 ESLint Code Explorer

Also, for accordions that can't be collapsed, I think we should change the cursor back to an arrow. Right now I still see the finger, which makes it look like the headers are collapsible.

@harish-sethuraman
Copy link
Member Author

Makes sense. The working of this accordion is different from the ones with the + sign. I was on the idea of standardising both but seems like it won't work for array values. I might have to look for other way to solve this. Will take some time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: use one level accordions for items inside the right pane
2 participants