Skip to content

Conversation

@xbinaryx
Copy link
Contributor

@xbinaryx xbinaryx commented Mar 9, 2025

This PR enhances the fetchPeerDependencies function by adding a fallback mechanism. If npm is unavailable, the function will now query the npm registry API directly to fetch peer dependencies.

Closes #84

@xbinaryx
Copy link
Contributor Author

I am not exactly sure who to ask for a review here, maybe @mdjermanovic?

@aladdin-add aladdin-add self-requested a review March 29, 2025 18:05
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM. Would like another review before merging.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 30, 2025
@aladdin-add aladdin-add moved this from Needs Triage to Second Review Needed in Triage Mar 30, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit d08a7a4 into eslint:main Apr 9, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Apr 9, 2025
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

package manager (npm, yarn, etc.) is not asked in style (How would you like to use ESLint) option

3 participants