Change Request: Disable CI `fail-fast` for matrix

[MikeMcC399]

Environment

ESLint version: ^9.11.1
@eslint/css version: HEAD
Node version: lts/* (currently 22.14.0)
npm version: 10.9.2
Operating System: ubuntu-latest / ubuntu-24.04

What problem do you want to solve?

In the workflow .github/workflows/ci.yml with job test the strategy.matrix uses the default strategy.fail-fast value of true so that any failed matrix jobs cause the whole higher level test job to be cancelled.

This is currently the case in https://github.com/eslint/css/actions/workflows/ci.yml due to eslint/csstree#27.

In general it is more convenient to allow all matrix jobs to run to their own independent completion. This gives a better overview of where failures are occurring. For example, they may affect all configurations, certain Node.js versions or certain operating system only.

What do you think is the correct solution?

In the workflow .github/workflows/ci.yml add fail-fast: true to the matrix parameters.

Participation

• I am willing to submit a pull request for this change.

Additional comments

No response

[MikeMcC399]

• Although in this case the failure cause has already been identified in Bug: <cubic-bezier-easing-function> is invalid csstree#27, in general it is easier to assess the situation if all jobs are run. For instance, we don't know from the results if only Ubuntu is affected or perhaps Windows and macOS as well:

We use fail-fast: false in a lot of similar Cypress workflows, so I feel confident proposing it here as well.

[nzakas]

Makes sense to me. 👍

[MikeMcC399]

@nzakas

Makes sense to me. 👍

Thanks! I'll soon go ahead with the PR in that case.

[MikeMcC399]

• See ci: disable fail-fast in matrix #106