-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: allow relative-size and global values in relative-font-units #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow relative-size and global values in relative-font-units #214
Conversation
Tanujkanti4441
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Everything looks good, just a minor change request.
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this.
There is no such thing as a math keyword in CSS, there are only math functions. Please update the logic and docs to take this into account.
|
@nzakas |
|
Huh. I didn't realize that was a literal value, I thought it was a reference to the math functions. TIL. 👍 |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Prerequisites checklist
What is the purpose of this pull request?
To update the
relative-font-unitsrule to more clearly and strictly enforce the use of relative font units, while always allowing relative-size keywords and global values, and always disallowing absolute-size keywords.What changes did you make? (Give an overview)
smallerandlargerrelative-size keywords.inherit,initial,revert,revert-layer, andunset.xx-small,x-small,small,medium,large,x-large,xx-large,xxx-large) and themathkeyword.Related Issues
Fixes #193
Is there anything you'd like reviewers to focus on?