feat: make var() regex multiline-safe in no-invalid-properties
#242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mdjermanovic
changed the title
no-invalid-properties
mdjermanovic
added
accepted
mdjermanovic
changed the title
no-invalid-propertiesno-invalid-properties
Member
|
Changed the tag to |
| ":root { --fallback-color: blue; }\na { color: VAR(--MY-COLOR, VaR(--fallback-color)) }", | ||
| "a { color: var(--my-color,\n red) }", | ||
| ":root { --my-color: red; }\na { color: var(--my-color,\n blue) }", | ||
| "a { color: var(--x,\n var(--y,\n blue\n )\n) }", |
Member
There was a problem hiding this comment.
This one was invalid before this change (false positive).
| ":root { --my-color: red; }\na { color: var(--my-color,\n blue) }", | ||
| "a { color: var(--x,\n var(--y,\n blue\n )\n) }", | ||
| "a { color: var(--x,\n red ) }", | ||
| ":root { --a: var(--b,\n 10px\n); } a { padding: var(--a); }", |
Member
There was a problem hiding this comment.
This one was invalid before this change (false positive).
Comment on lines
+1000
to
+1017
| { | ||
| code: "a { padding-top: var(--a,\nvar(--b, red\n)\n); }", | ||
| options: [{ allowUnknownVariables: true }], | ||
| errors: [ | ||
| { | ||
| messageId: "invalidPropertyValue", | ||
| data: { | ||
| property: "padding-top", | ||
| value: "red", | ||
| expected: "<length-percentage [0,∞]>", | ||
| }, | ||
| line: 1, | ||
| column: 18, | ||
| endLine: 4, | ||
| endColumn: 2, | ||
| }, | ||
| ], | ||
| }, |
Member
There was a problem hiding this comment.
This one was valid before this change (false negative).
mdjermanovic
approved these changes
Aug 27, 2025
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for a second review.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix the
var()parsing to handle multiline fallbacks safely and avoid super-linear backtracking.What changes did you make? (Give an overview)
Related Issues
#229 (comment)
Is there anything you'd like reviewers to focus on?