refactor: replace findOffsets helper with native methods
#272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
previously approved these changes
Sep 25, 2025
Contributor
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Net 62 lines reduced, all tests still passing, very nice 👌
Someone who's more deeply familiar with CSS than me should still review. But this is very lovely to see!
lumirlumir
added
the
accepted
… of https://github.com/eslint/css into refactor-replace-findoffset-helper-with-native-methods
Member
Author
|
I've updated this PR in 1449877 to apply the feedback from eslint/markdown#541. |
nzakas
deleted the
refactor-replace-findoffset-helper-with-native-methods
branch
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've replaced the
findOffsetsutility helper function with the nativegetLocFromIndexthat was recently added in #167.As a result of this cleanup, the code has been simplified.
I've used the
dflag for theimportantPatternregex to improve readability and make the intention clearer.There might be a cleaner solution; if so, I'd be happy to take a look.
What changes did you make? (Give an overview)
In this PR, I've replaced the
findOffsetsutility helper function with the nativegetLocFromIndexthat was recently added in #167.Related Issues
Refs: #167, eslint/rewrite#212
Is there anything you'd like reviewers to focus on?
N/A