fix: correct message for functions in use-baseline rule
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Pixel998
approved these changes
Oct 13, 2025
Contributor
Pixel998
left a comment
Pixel998
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for a second review before merging.
Pixel998
added
the
accepted
nzakas
reviewed
Oct 14, 2025
| export const atRules = new Map(${JSON.stringify(Object.entries(cssFeatures.atRules), null, "\t")}); | ||
| export const mediaConditions = new Map(${JSON.stringify(Object.entries(cssFeatures.mediaConditions), null, "\t")}); | ||
| export const types = new Map(${JSON.stringify(Object.entries(cssFeatures.types), null, "\t")}); | ||
| export const functions = new Map(${JSON.stringify(Object.entries(cssFeatures.functions), null, "\t")}); |
Member
There was a problem hiding this comment.
I don't think this is the correct approach here. Let's keep types as-is and just add functions.
Contributor
Author
There was a problem hiding this comment.
The "types" here are actually just functions. We're filtering the css.types.* entries through mdnData.css.functions to extract only the ones that represent actual CSS functions.
css/tools/generate-baseline.js
Lines 158 to 160 in c6c5b9d
Member
There was a problem hiding this comment.
Ah gotcha, thanks for explaining. 👍
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request fixes an inaccurate error message in the
use-baselinerule. Previously, CSS functions (such aslight-dark()andcolor-mix()) were reported as “types,” which was misleading. The rule will now correctly refer to them as “functions.”What changes did you make? (Give an overview)
types→functions.use-baselinerule to:functionsinstead oftypes.notBaselineTypewithnotBaselineFunction.functionsconsistently.Related Issues
Fixes #293
Is there anything you'd like reviewers to focus on?