-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add selector support to require-baseline #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wasn't sure how to handle selectors used within Example CSS: @supports selector(.example) {}AST: {
"type": "Function",
"loc": {
"source": "<unknown>",
"start": {
"offset": 10,
"line": 1,
"column": 11
},
"end": {
"offset": 28,
"line": 1,
"column": 29
}
},
"name": "selector",
"children": [
{
"type": "Raw",
"loc": {
"source": "<unknown>",
"start": {
"offset": 19,
"line": 1,
"column": 20
},
"end": {
"offset": 27,
"line": 1,
"column": 28
}
},
"value": ".example"
}
]
} |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started. The basics are here, there are a couple of edge cases that need addressing.
|
This is looking really good. I think the last step here is to update the docs with some examples that use |
|
Great thanks, added another example to the docs. |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks so much for this. Great work.
Prerequisites checklist
What is the purpose of this pull request?
Add support for validating the Baseline status of selectors like
:has()What changes did you make? (Give an overview)
Selectorhandler that checks the validity of all child nodesRelated Issues
Fixes #60
Is there anything you'd like reviewers to focus on?