Skip to content

Commit

Permalink
Fix: Install required eslint plugin for "standard" guide (fixes #6656) (
Browse files Browse the repository at this point in the history
#6657)

`eslint-config-standard` peer depends on `eslint-plugin-promise`, so
let's install that for users.
  • Loading branch information
feross authored and alberto committed Jul 12, 2016
1 parent 720686b commit a8b4e40
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/config/config-initializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ function getConfigForStyleGuide(guide) {
var guides = {
google: {extends: "google"},
airbnb: {extends: "airbnb", plugins: ["react"]},
standard: {extends: "standard", plugins: ["standard"]}
standard: {extends: "standard", plugins: ["standard", "promise"]}
};

if (!guides[guide]) {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/config/config-initializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ describe("configInitializer", function() {
it("should support the standard style guide", function() {
var config = init.getConfigForStyleGuide("standard");

assert.deepEqual(config, {extends: "standard", installedESLint: true, plugins: ["standard"]});
assert.deepEqual(config, {extends: "standard", installedESLint: true, plugins: ["standard", "promise"]});
});

it("should throw when encountering an unsupported style guide", function() {
Expand Down

0 comments on commit a8b4e40

Please sign in to comment.