-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator-star ignores object literal shorthand methods #1680
Comments
The Esprima issue has been moved to jquery/esprima#1029. |
The parser issue has been fixed with jquery/esprima#1036 and eslint/js#61. The next release of Espree will unblock this issue. |
I'll plan on doing that this weekend. |
Espree has been upgraded, so this is unblocked. |
Edit: I was trying to figure out what the expected behavior should be here ( |
This should fail due to the space between the asterisk and the method name:
#1678 was merged because #1677 was more important than this case. That PR prevented generator-star from checking star position for shorthand methods because a parser fix or workaround will be required. This issue is blocked until a decision is made in eslint/js#36 (and Esprima issue 625) regarding node ranges for shorthand methods.
The text was updated successfully, but these errors were encountered: