Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator-star ignores object literal shorthand methods #1680

Closed
btmills opened this issue Jan 19, 2015 · 5 comments
Closed

generator-star ignores object literal shorthand methods #1680

btmills opened this issue Jan 19, 2015 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly good first issue Good for people who haven't worked on ESLint before

Comments

@btmills
Copy link
Member

btmills commented Jan 19, 2015

This should fail due to the space between the asterisk and the method name:

// "generator-star": [2, "end"]
({
    * method() {}
})

#1678 was merged because #1677 was more important than this case. That PR prevented generator-star from checking star position for shorthand methods because a parser fix or workaround will be required. This issue is blocked until a decision is made in eslint/js#36 (and Esprima issue 625) regarding node ranges for shorthand methods.

@btmills btmills added the blocked This change can't be completed until another issue is resolved label Jan 19, 2015
@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly labels Jan 19, 2015
@btmills
Copy link
Member Author

btmills commented Feb 14, 2015

The Esprima issue has been moved to jquery/esprima#1029.

@btmills btmills added blocked This change can't be completed until another issue is resolved and removed blocked This change can't be completed until another issue is resolved labels Feb 17, 2015
@btmills
Copy link
Member Author

btmills commented Feb 17, 2015

The parser issue has been fixed with jquery/esprima#1036 and eslint/js#61. The next release of Espree will unblock this issue.

@nzakas
Copy link
Member

nzakas commented Feb 18, 2015

I'll plan on doing that this weekend.

@nzakas nzakas removed the blocked This change can't be completed until another issue is resolved label Feb 21, 2015
@nzakas
Copy link
Member

nzakas commented Feb 21, 2015

Espree has been upgraded, so this is unblocked.

@nzakas nzakas added the good first issue Good for people who haven't worked on ESLint before label Feb 22, 2015
@btmills
Copy link
Member Author

btmills commented Mar 6, 2015

Edit: I was trying to figure out what the expected behavior should be here (end is easy, but start and middle are more complex), but the logic and error messages as they are now don't give me enough information to know what the intention really is. So I opened #1949 to figure that out for the whole rule.

nzakas added a commit that referenced this issue Mar 14, 2015
New: generator-star-spacing rule (fixes #1680, fixes #1949)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly good first issue Good for people who haven't worked on ESLint before
Projects
None yet
Development

No branches or pull requests

2 participants