Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: link to JSDoc EOL blogpost in valid-jsdoc and require-jsdoc #11191

Merged
merged 3 commits into from
Dec 13, 2018
Merged

Docs: link to JSDoc EOL blogpost in valid-jsdoc and require-jsdoc #11191

merged 3 commits into from
Dec 13, 2018

Conversation

ibbignerd
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Linked in to the end of life blog post regarding the deprecation of JSDoc rules. It took a bit of searching to find the post when it could just be linked here.

Is there anything you'd like reviewers to focus on?
N/A

@jsf-clabot
Copy link

jsf-clabot commented Dec 13, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 13, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ibbignerd
Copy link
Contributor Author

@not-an-aardvark Does the commit message need to be fixed? Also should commits be squashed?

@not-an-aardvark not-an-aardvark changed the title Update documentation for valid-jsdoc and require-jsdoc with links to end of life blog post Docs: link to JSDoc EOL blogpost in valid-jsdoc and require-jsdoc Dec 13, 2018
@not-an-aardvark not-an-aardvark merged commit 733d936 into eslint:master Dec 13, 2018
@not-an-aardvark
Copy link
Member

No need this time, I fixed the PR title for you. It's not necessary to squash commits because we squash them when merging.

Thanks for contributing!

@ibbignerd ibbignerd deleted the jsdoc-link-to-blog branch December 13, 2018 05:31
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 12, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants