Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: corrected class extension example #12176

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Docs: corrected class extension example #12176

merged 1 commit into from
Aug 28, 2019

Conversation

mariuscm
Copy link
Contributor

@mariuscm mariuscm commented Aug 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
I switched the parent and child class names for the class extension examples in the rules for no-useless-constructor

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Aug 27, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 27, 2019
@mariuscm mariuscm changed the title corrected class names Docs: corrected class extension example Aug 28, 2019
@mariuscm mariuscm closed this Aug 28, 2019
@mariuscm
Copy link
Contributor Author

corrected commit message and explained changes

@mariuscm mariuscm reopened this Aug 28, 2019
@g-plane g-plane added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Aug 28, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes a lot of sense. Thanks for contributing to ESLint!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing to ESLint!

@aladdin-add aladdin-add merged commit 00d2c5b into eslint:master Aug 28, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants