fix: add ; after JSX nodes in no-object-constructor autofix

[fasttime]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment (npx eslint --env-info):

Node version: v21.0.0
npm version: v10.2.0
Local ESLint version: v8.52.0 (Currently used)
Global ESLint version: v8.52.0
Operating System: darwin 23.0.0

What parser are you using (place an "X" next to just one item)?

[X] Default (Espree)
[ ] @typescript-eslint/parser
[ ] @babel/eslint-parser
[ ] vue-eslint-parser
[ ] @angular-eslint/template-parser
[ ] Other

Please show your full configuration:

Configuration

{
    "parserOptions": {
        "ecmaFeatures": {
            "jsx": true
        },
        "ecmaVersion": "latest"
    }
}

What did you do? Please include the actual source code causing the issue.

/* eslint no-object-constructor: error */

const a = <foo />
Object()

const b = <bar></bar>
Object()

Playground demo

What did you expect to happen?

Autofixing no-object-constructor should add a semicolon after the closing token > of a JSX node, because ASI no longer happens when Object() is replaced with a parenthesized expression.

What actually happened? Please include the actual, raw output from ESLint.

The autofix is wrong. While rechecking these changes in the Playground after the last release, I noticed that I had misplaced the JSX unit tests. My apologies for the mistake.

What changes did you make? (Give an overview)

Fixed the autofix logic and moved the JSX unit tests into the right block, where autofix is expected to add a semicolon.

Is there anything you'd like reviewers to focus on?

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	eb11239
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/65338099aba0ff0008023303

[mdjermanovic]

Interesting, I remember that while reviewing #17649 I checked if ASI applies after JSX on AST Explorer and it appeared to me as if it does apply but now it seems that only @typescript-eslint/parser works that way (snippet) so I must have had that parser on.

[mdjermanovic]

LGTM, thanks! Will merge this after we close #17636. I think this doesn't qualify as regression as v8.52.0 works the same as v8.51.0 for these cases.

[fasttime]

Interesting, I remember that while reviewing #17649 I checked if ASI applies after JSX on AST Explorer and it appeared to me as if it does apply but now it seems that only @typescript-eslint/parser works that way (snippet) so I must have had that parser on.

In fact, TypeScript seems to be way more generous than JavaScript in semicolon insertion. While testing the autofix on TypeScript code, I stumbled upon many examples where the it would insert an unnecessary semicolon, but not a single case where it would miss inserting an otherwise required semicolon.