-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update WebdriverIO packages #18558
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
"@wdio/browser-runner": "^8.38.3", | ||
"@wdio/cli": "^8.38.2", | ||
"@wdio/concise-reporter": "^8.38.2", | ||
"@wdio/globals": "^8.38.2", | ||
"@wdio/mocha-framework": "^8.38.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, but the browser tests are still failing. Reference
@christian-bromann it looks like this is still failing, can you take a look? |
@nzakas @aladdin-add not sure why it was failing but I don't see them failing anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's try this since the tests often fail with pinned 8.36.0 anyway.
Please keep me posted if failures pop up again. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18548
What changes did you make? (Give an overview)
I update the WebdriverIO packages for browser tests to pass again more reliable. WebdriverIO has released v8.38.3 which fixes some performance issues we've discovered with some changes introduced to the test harness in Eslint.
Is there anything you'd like reviewers to focus on?