-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async shorthand functions cause parsing errors if they are named 'delete' or 'import' #352
Comments
Thank you for this issue. This has been fixed already on the master branch of upstream: acornjs/acorn#584. |
Unfortunately updating acorn isn't enough as espree seems to be overriding this issue. I've just created #353 with the fix ported across. |
Oops, I'm sorry, I had forgotten that. |
Closed in 5eb1388 |
I'm just wondering if there is a likely ETA for when the fix for this could be included in a release? Currently I'm trying to resolve a few issues with dependencies in one of the modules I'm working on for Firefox, but I'm hitting up against this issue at the moment. Having an ETA would be useful for knowing when I can get back to fixing it. Thanks. |
We had been planning to release it along with the scheduled ESLint release next week. If there's someone waiting on the fix we might be able to do it sooner though. |
@not-an-aardvark Next week is fine, it'll be good timing for us. |
Using ESLint, with Espree 3.5.0, we are seeing failures that we were not seeing with 3.4.3.
Example failure:
With 3.5.0 this fails with
Parsing error: Unexpected token import
Downgrading to 3.4.3 or changing the name of the function to something else, e.g.
bar
passes.We've also seen that
async delete() {}
causes a similar issue.I suspect this is a regression from #341 given the release notes.
The text was updated successfully, but these errors were encountered: