Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sourcemap url #566

Closed
tjx666 opened this issue Mar 19, 2023 · 7 comments · Fixed by #567
Closed

remove sourcemap url #566

tjx666 opened this issue Mar 19, 2023 · 7 comments · Fixed by #567

Comments

@tjx666
Copy link
Contributor

tjx666 commented Mar 19, 2023

image

version: espree@9.5.0

@Rec0iL99
Copy link
Member

Hi @tjx666, thanks for the issue. The sourceMappingURL comment is autogenerated by rollup and helps navigate to the source map file and finally to the original source code during debugging. I believe this comment is generated by rollup because of sourcemap: true in rollup.config.js.

@Rec0iL99 Rec0iL99 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@tjx666
Copy link
Contributor Author

tjx666 commented Mar 19, 2023

@Rec0iL99

You should set sourcemap: false when build for production, or it will cause debugger tools issue because you declare the sourceMappingURL but not actually exists;

image

@aladdin-add
Copy link
Member

instead, I think we should publish the sourcemap files, for better debugging.

@nzakas nzakas reopened this Mar 20, 2023
@nzakas
Copy link
Member

nzakas commented Mar 20, 2023

We don't actually need the source files for debugging as the source is in ESM already. We should just remove sourcemap:true from rollup.config.js.

tjx666 pushed a commit to tjx666/espree that referenced this issue Mar 22, 2023
@tjx666
Copy link
Contributor Author

tjx666 commented Mar 22, 2023

@nzakas #567

@mdjermanovic
Copy link
Member

@nzakas was this intentionally labeled as a breaking change?

tjx666 pushed a commit to tjx666/espree that referenced this issue Mar 22, 2023
@nzakas nzakas added bug and removed breaking labels Mar 22, 2023
@nzakas
Copy link
Member

nzakas commented Mar 22, 2023

Oops! No. I meant to label as "bug". Thanks for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants