Chore: upgrade acorn@5.2 (fixes #358) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
OK, I fixed library tests. I believe the change of library tests is only |
not-an-aardvark
approved these changes
Oct 30, 2017
mysticatea
changed the title
mysticatea
changed the title
ilyavolodin
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358.
This PR upgrades acorn to
5.2.1.It has a feature and several bug fixes.
I fixed some tests because new acorn makes
ExpressionStatement#directiveproperty for directive prologues. This is by ESTree updating.This PR is WIP since it doesn't finish the tests for
tests/fixtures/libraries/angular-1.2.5.js.