Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: es module proof of concept DO NOT MERGE :) fixes #457 #458

Closed
wants to merge 3 commits into from
Closed

Build: es module proof of concept DO NOT MERGE :) fixes #457 #458

wants to merge 3 commits into from

Conversation

mreinstein
Copy link
Contributor

changes:

  • convert source from commonjs to import/export
  • modify package.json to support both cjs and es modules
  • generate a commonjs (cjs) build in dist/
  • generate a umd build in dist/
  • use rollup for building the umd and cjs code

@eslint-deprecated
Copy link

Hi @mreinstein!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@mreinstein mreinstein changed the title Es module proof of concept DO NOT MERGE :) fixes #457 Build: es module proof of concept DO NOT MERGE :) fixes #457 Nov 18, 2020
@eslint-deprecated
Copy link

Hi @mreinstein!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The issue reference must be formatted as follows:

    If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn't completely fix the issue, then use (refs #1234) instead of (fixes #1234).

    Here are some good commit message summary examples:

    Build: Update Travis to only test Node 0.10 (refs #734)
    Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
    Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)
    

Read more about contributing to ESLint here

@mreinstein
Copy link
Contributor Author

closed in favor of #469

@mreinstein mreinstein closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant