Breaking: acorn to 8.1.0 (fixes #470) #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
changed the title
nzakas
requested changes
Apr 10, 2021
aladdin-add
changed the title
aladdin-add
changed the title
aladdin-add
force-pushed
the
upgrade/acorn
branch
from
931e56f to
71663a0
Compare
aladdin-add
commented
Apr 12, 2021
|
I think this is ready to be reviewed and merged. 🚀 But if #469 get merged before this one. I will update the title to "Chore" as @mdjermanovic suggested. |
mdjermanovic
requested changes
Apr 15, 2021
tests/lib/parse.js
Outdated
Comment on lines
117
to
119
| assert.throws(() => { | ||
| espree.parse("async () => await 5 ** 6;"); | ||
| }); |
There was a problem hiding this comment.
Similar to the above, we should set a higher ecmaVersion to confirm that #472 has been fixed, because this code with the default ecmaVersion already has syntax errors aside from await 5 ** 6.
Actually, it seems that this particular example doesn't throw in the latest Acorn 8.
There was a problem hiding this comment.
interesting! if adding a {}, it will throw an error.
> acorn.parse('async() => { await 5 ** 6 }', {ecmaVersion: 10})
Uncaught [SyntaxError: Unexpected token (1:21)
] {
pos: 21,
loc: Position { line: 1, column: 21 },
raisedAt: 23
}sounds like a bug in acorn?
There was a problem hiding this comment.
just removed the case, as it was not fixed in latest acorn. :)
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
aladdin-add
force-pushed
the
upgrade/acorn
branch
from
a4ca5b5 to
97fecf5
Compare
aladdin-add
changed the title
nzakas
approved these changes
Apr 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #470
changelog:
https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#breaking-changes