New: Add modules feature flag (refs #72) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This basically switches to using Still a bunch of tests missing (for classes, strict mode, etc.), but this should be a good foundation to build upon. |
This was referenced Mar 6, 2015
| @@ -1,148 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Love putting the modules back in ecma-features!
There was a problem hiding this comment.
Really that was @caridy's original idea. Just took me a while to see that he was right. :)
|
Do you want to sneak something like caridy#1 here as well? (As its just a few lines) |
|
Was hoping I could get you to do that after I merge this :) |
|
Sure!
|
nzakas
added a commit
that referenced
this pull request
Mar 6, 2015
New: Add modules feature flag (refs #72)
|
Okay, all ready for you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.