feat: Add support for config comments #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds support for rule configuration comments and disable directives.
What changes did you make? (Give an overview)
Added
getInlineConfigNodes()
,getDisableDirectives()
andapplyInlineConfig()
methods to theJSONSourceCode
class.Related Issues
Fixes #21
Is there anything you'd like reviewers to focus on?
Unlike the JS language implementation (SourceCode in eslint/eslint), in this implementation rule configs,
eslint-disable
andeslint-enable
can be Line comments. We wanted to implemented this in the JS language as well (eslint/rfcs#34), and eventually did but reverted the change due to backwards compatibility reasons (eslint/eslint#14960). Since there were no backwards compatibility concerns here, it seemed fine to allow this, but let me know if it would be better to have the same behavior as in the JS language (e.g., ignore comments like// eslint rule
).