feat: expose identifiers in messages for no-empty-definitions#507
Merged
nzakas merged 1 commit intoeslint:mainfrom Aug 19, 2025
Merged
Conversation
The committers listed above are authorized under a signed CLA. |
1 task
lumirlumir
approved these changes
Aug 12, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging, since it's a small change but adds a new feature.
lumirlumir
reviewed
Aug 12, 2025
| messages: { | ||
| emptyDefinition: "Unexpected empty definition found.", | ||
| emptyDefinition: | ||
| "Unexpected empty definition `{{ identifier }}` found.", |
Member
There was a problem hiding this comment.
To the team: I think using backticks here would be fine, since the similar rule no-unused-definition uses backticks as well.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
|
Nice work @Nohgh 🎉🎉🎉 |
Member
|
@Nohgh we'd like to pay you for this contribution. Please contact us contact (at) eslint (dot) org so we can send you the details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Enhance the
no-empty-definitionsrule to include identifier data in its verification process,ensuring more informative and accurate error messages.
What changes did you make? (Give an overview)
no-empty-definitionsrule logic to verify and expose identifier data.no-empty-definitions.test.jsto cover new behavior.Related Issues
refs #499
Is there anything you'd like reviewers to focus on?