Skip to content

Conversation

@sethamus
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Simplify Bun detection in tests by replacing the verbose checks with the direct process.versions.bun detection

What changes did you make? (Give an overview)

Replaced all instances of typeof process !== "undefined" && process.release?.name === "node" && !process.versions?.bun with !process.versions.bun where tests should skip running on Bun.

Related Issues

Fixes #540

Is there anything you'd like reviewers to focus on?

@eslintbot eslintbot added this to Triage Sep 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 30, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Sep 30, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Very nice cleanup.

@lumirlumir lumirlumir merged commit bae7da7 into eslint:main Sep 30, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Simplify Bun detection in tests

2 participants