fix: handle CR in MarkdownSourceCode and Front Matter util
#554
+93
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Which language are you using?
CommonMark and GFM.
What did you do?
@eslint/markdownis unable to recognize CR line endings in theMarkdownSourceCodeclass, as well as in rules and processors.What did you expect to happen?
I expect CR line endings to be recognized as valid line endings throughout the Markdown plugins.
According to the Markdown(CommonMark) specification, LF, CR, and CRLF can all be used for line endings.
https://spec.commonmark.org/0.31.2/#line-ending
Link to minimal reproducible Example
Adding the following test case to the
tests/language/markdown-source-code.test.jswould help identify the problem:What changes did you make? (Give an overview)
This PR originated from #493. While working on that, I found the scope had become too large, so I split this fix into a separate PR.
In this PR, I've fixed an issue where
MarkdownSourceCodeand the Front Matter utility could not handle CR line endings.Notable changes:
MarkdownSourceCodeto recognize CR line endings.frontmatterHasTitleutility to recognize CR and CRLF line endings.Related Issues
Ref: #493, eslint/css#275
Is there anything you'd like reviewers to focus on?
I'll update the rules and processors to recognize CR in #493. This PR is separate from that one to keep the scope smaller.