-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Configuring core options in Config Files #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this RFC! I left a few thoughts.
linterOptions
property in Config FilescoreOptions
property in Config Files
@not-an-aardvark Thank you for your feedback. I updated this RFC. I think it has addressed your concerns. |
Oh, thank you. I have fixed the link. |
coreOptions
property in Config Files
I have updated this RFC for some feedback.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns from me at this point.
@kaicataldo @not-an-aardvark Does the latest update solve your concerns? If so, I will move this RFC to the final commenting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about renaming property names, but otherwise this LGTM. Thanks for working on this!
Summary
This RFC adds several properties into config files to configure core options. People can use config files (including shareable configs!) instead of CLI options in order to configure some linter behavior.
Related Issues
reportUnusedDisableDirectives
in config files.
by default