Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Make compatible with TypeScript 2.1 #128

Closed
flying-sheep opened this issue Dec 18, 2016 · 6 comments
Closed

Make compatible with TypeScript 2.1 #128

flying-sheep opened this issue Dec 18, 2016 · 6 comments

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Dec 18, 2016

When installing TypeScript 2.1, tests start to fail. This is why travis is currently failing for every PR.

We should handle the AST it produces.

This was referenced Dec 18, 2016
@soda0289
Copy link
Member

I will take a look at some of these tests.

@JamesHenry
Copy link
Member

JamesHenry commented Jan 2, 2017

I'm looking into this now. I will be putting together a list of updates needed on this issue:

  • Update devDependency and peerDependency to ~2.1.5

Updates relating to existing tests which break when updating the version:

  • exclude new modifierFlagsCache property during TSNode auto-conversion
  • update detection for static modifier. There is now ts.ModifierFlags.
  • TS SyntaxKind.SpreadElementExpression has been changed. Now there is SyntaxKind.SpreadElement and SyntaxKind.SpreadAssignment
  • JSDoc-style comment handling has changed and is causing all of the tokens to be skipped in one test case. This was also the behaviour highlighted in Parser does not handle jsdoc well #118 by @jtheoof

The WIP is available on the branch ts-2.1, it can't be merged until all the work is completed because the move from TS 2.0.x to TS 2.1.x is a breaking change for this parser.

@JamesHenry
Copy link
Member

Just FYI, I have asked for some feedback from the TypeScript on the final point, as I would love to get this over the line:

microsoft/TypeScript#13519

@JamesHenry
Copy link
Member

This has been confirmed as a TypeScript bug, so unfortunately the upgrade to 2.1.x is blocked for now

@jtheoof
Copy link
Contributor

jtheoof commented Jan 20, 2017

Thanks for the feedback @JamesHenry.

@JamesHenry
Copy link
Member

I have a final update on this, but this issue has gotten rather messy, and it was not my original description, so I am going to start a new one which just summarises how ts-2.1 support works for this parser.

The instructions are here: #149

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants