ClassProperty and MethodDeclaration Visibility Declarations

[dannyfritz]

What version of TypeScript are you using?
2.0.2

What version of typescript-eslint-parser are you using?
0.2.0

What code were you trying to parse?

class Animal {
  public name: string
}

What did you expect to happen?
I expected an ASTNode for ClassProperty with public represented on it.

What happened?
I had to use context.getText(node) to do a string find for the visibility declaration. I'm wondering if I either missed something or if we are missing it in the conversion.

---

References this PR on the typescript-plugin bradzacher/eslint-plugin-typescript#4 (comment)

[nzakas]

The public is represented in the TypeScript AST, we just aren't converting it.

[dannyfritz]

I'll take another look later today because I was looking in the TS AST I thought for it. Could you be more specific? Or is there a handbook for the TS AST somewhere? Otherwise I'll just take a more scrutinous look later today.

[nzakas]

I just used astexplorer.net with your example

[dannyfritz]

I can work on this.

Also thanks for astexplorer.net. This is a great tool.

[nzakas]

Cool!

I think we probably just want to add a visibility property to the ClassProperty and MethodDefinition nodes, with a possible value of null (if not present), "private", or "public".

[dannyfritz]

I was thinking about putting it under modifiers as that is what TS AST seems to do.

---

I'm having some trouble figuring out the tests. Quite a few of the JSX ones are failing for me out of the gate which I assume is known. Using TS 2.0.2 and master of this parser.

[nzakas]

We don't support TypeScript 2 yet, so the errors are expected. Try installing TypeScript 1.8 instead.

For the AST, modifiers in the TS AST tend to refer to all kinds of things, things that ESTree tends to put directly on a node. For instance async ends up in the modifiers array, but in ESTree, async is a property on the node.

So the visibility approach I mentioned in more in format that ESTree tends to present things.

[dannyfritz]

👍 Thanks for the guidance.

[JamesHenry]

Just FYI, the TypeScript spec refers to this in terms of "accessibility", rather than "visibility":

https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#822-accessibility