Breaking: typescript-estree to 18.0.0 and typescript to 3.2.1

[armano2]

This PR contains changes from #576, #584, #589, #590, #591, #592 and deprecates changes from #581

v18.0.0 - v5.3.0 changes:

JamesHenry/typescript-estree@v5.3.0...v18.0.0

PRs with changes to ast:

• feat(ast): heritage array is now optional, not empty array JamesHenry/typescript-estree#120
• feat: change logic of distinguishing patterns from statements JamesHenry/typescript-estree#118
• refactor: add explicit implementation of TSLiteralType JamesHenry/typescript-estree#117
• feat: fix regression in TSTypeParameter node JamesHenry/typescript-estree#111
• feat: rest element should contain information about type annotation JamesHenry/typescript-estree#108
• feat: update TSMethodSignature node JamesHenry/typescript-estree#104
• fix: functions without body should be TSDeclareFunctions JamesHenry/typescript-estree#98
• feat: update TSFunctionType and TSConstructorType nodes JamesHenry/typescript-estree#91
• feat: add missing TSNamespaceExportDeclaration node JamesHenry/typescript-estree#87
• feat: fix parsing comments in jsx JamesHenry/typescript-estree#82
• BREAKING: add missing TSTypeAssertion node JamesHenry/typescript-estree#79
• fix: set parent nodes correctly for virtual files JamesHenry/typescript-estree#78
• fix: change incorrect FirstNode to QualifiedName JamesHenry/typescript-estree#76
• fix: add Decorator to tree node maps JamesHenry/typescript-estree#75
• BREAKING: correct nodes TSConstructorType and TSConstructorType JamesHenry/typescript-estree#74
• fix: add missing TSThisType no known nodes JamesHenry/typescript-estree#73
• BREAKING: add missing TSImportEqualsDeclaration node JamesHenry/typescript-estree#71
• test: refactor omitDeep function to support type changes JamesHenry/typescript-estree#70
• feat: add missing TSAsExpression node JamesHenry/typescript-estree#69
• fix: add missing TSInferType node JamesHenry/typescript-estree#68
• fix: Fix issues with parsing types and directives JamesHenry/typescript-estree#65
• feat: add errorOnTypeScriptSyntaticAndSemanticIssues option JamesHenry/typescript-estree#57
• refactor: replace internal typescript method call with hasModifier JamesHenry/typescript-estree#48
• refactor: mark AsteriskAsteriskEquals as assignment operator JamesHenry/typescript-estree#46
• feat: fix issues in AST JamesHenry/typescript-estree#42

fixes: #414, #588, #384, #593

[armano2]

there is one test witch i'm thinking about adding, but i'm unsure if i should do it here or as separate pr:

const { AST_NODE_TYPES } = require("typescript-estree/dist/ast-node-types");
const visitorKeys = require("../../visitor-keys");
const astTypes = Object.keys(AST_NODE_TYPES);
describe("visitor-keys", () => {
    for (const type of astTypes) {
        test(`type ${type} should be present in visitor-keys`, () => {
            expect(visitorKeys).toHaveProperty(type);
        });
    }
});

this will ensure that we have all supported nodes by typescript-estree in visitor-keys

from this test i can see that we are still missing 5 node types :(
ClassImplements, Import, JSXClosingFragment, JSXOpeningFragment, JSXSpreadChild

[JamesHenry]

@armano2 I am back reviewing PRs on this side of the fence again :)

I'm strongly of the opinion that we should just jump straight to this PR and close your other ones. Thanks for putting all of these different ones together and making the options available.

Maybe we could creates some failing tests related to the missing visitor keys in a follow up PR?

[JamesHenry]

Thanks so much!

[armano2]

should i upgrade it to 16.x.x 17.x.x ?

[JamesHenry]

We should be able to release 18 today (the heritage related PR) and then draw a line under the major changes in this batch :)

[platinumazure]

@JamesHenry Just to make sure I'm following- are you suggesting that typescript-estree will release 18.x soon and we should jump to that, closing this PR at that point?

@armano2 I agree we can do a follow up PR to add the missing visitor keys- as soon as I'm clear on what version of typescript-estree we want to migrate to (see above), we'll get that in and then have a couple of days where the other PRs will need to rebase- during that time you can write a PR for the new test. Sound good?

[JamesHenry]

Yes, exactly 👍

[JamesHenry]

18 is out now and should hopefully be the last major change for a little while now. We'll work on catching things up here next

[armano2]

ok, PR updated with changes for v18

[armano2]

@JamesHenry looks like not all tickets got closed
#588, #384, #593

[siebertm]

Are there any plans for a new release soon? This kindof blocks me from upgrading typescript to 3.2...

[Jessidhia]

A workaround that can be used with yarn, as long as you have no BigInt syntax in your code, is:

  "resolutions": {
    "**/typescript-eslint-parser/typescript-estree": "6.0.0"
  }

This must, of course, be removed as soon as the ecosystem updates, or there will be pain.

[corbinu]

I also have been maintaining a kind of nightly @corbinu/typescript-eslint-parser

I will say in the latest version typescript/no-empty-interface seems to be broken so I did turn it off