-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some changes to vcs #1203
Draft
mandresm
wants to merge
12
commits into
release
Choose a base branch
from
feat/vcs
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
add some changes to vcs #1203
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6222075
add some changes to vcs
mandresm b429372
feat: vcs should be able to read from cache if possible
pgierz 90ed76d
wrong comparison
pgierz 6863c1e
feat: adds dummy hello-world fortran component
pgierz 6c05de0
wip
pgierz df61121
test for vcs helpers
pgierz 79984f3
ci debugging
pgierz a95b69c
Fucking submodule bull shit
pgierz 055f5dc
It Compiles! 50 Points For Gryffindor.
pgierz 7628863
Testing the test
pgierz 6c1377e
I expected something different.
pgierz 58cf286
audit log
pgierz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to think about this, maybe we want to compare it with the age of the binary: is not until one compiles it and uses the binary that the diff needs to be refreshed?
At the same time we need to check whether the binary in the model dir and in the work folder are the same, because ESM-Tools does not update the bin in a simulation unless you run esm_runscripts with the option
--update-files=bin
(or some argument like that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't entirely sure about this, I'll think more about it. At the moment, it checks the modification time of the directory. The naive assumption that "changing a file in a directory will change the modification time of the directory" is wrong, apparently:
...so I'll need to think of something else. But that is just a matter of changing the logic inside
is_younger_than
. (I like this name, it makes it easy to read 😉)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The access time changes, maybe we can use that...