-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix echam hist ssp forcing #1246
Open
chrisdane
wants to merge
24
commits into
release
Choose a base branch
from
fix_echam_hist_ssp_forcing
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n; updated comments
…and recom output defs
I need to book time for this PR. It will have a big impact in multiple research groups so it cannot be just merged. I will only have this ammount of time by the end of January. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
In the current release (
595f0b4b
),echam.yaml:allow_hist2ssp_transition
does not seem to work (for year 2015, i.e. the first ssp-year, not all forcing files are found in anawicm-1.0-recom
experiment on levante).In addition, the rationale in
echam.yaml
:is imho not the best choice, as it leads to e.g.
which I find rather confusing (are they hist or scenario or both?!), as well as to
, which does not make too much sense since
cmip6
is not an experiment/scenario.So this PR is merely a restructuring of how paths of echam+jsbach forcing files+namelists are constructured. I tested it in many CMIP6 historical and ssp* experiments with the
awicm-1.0-recom
setup.Over time some small additions in recom were added as well. Please excuse the delay in pushing this.
Kind regards,
Chris