Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix echam hist ssp forcing #1246

Open
wants to merge 24 commits into
base: release
Choose a base branch
from
Open

Conversation

chrisdane
Copy link
Contributor

Hi

In the current release (595f0b4b), echam.yaml:allow_hist2ssp_transition does not seem to work (for year 2015, i.e. the first ssp-year, not all forcing files are found in an awicm-1.0-recom experiment on levante).

In addition, the rationale in echam.yaml:

choose_scenario:
        HIST:
                forcing_files:
                        ozone: ozone_hist_scenario
                        greenhouse: greenhouse_hist_scenario
                        MAC-SP: MAC-SP_hist_scenario
        cmip6hist:
                scenario_type: cmip6
        ssp126:
                scenario_type: cmip6

is imho not the best choice, as it leads to e.g.

choose_scenario_type:
        cmip6:
                forcing_files:
                        ozone: ozone_hist_scenario
                        greenhouse: greenhouse_hist_scenario
                        MAC-SP: MAC-SP_hist_scenario

which I find rather confusing (are they hist or scenario or both?!), as well as to

ls namelists/echam/<echam_version>
...
HIST/
...
PI-CTRL/
cmip6/

, which does not make too much sense since cmip6 is not an experiment/scenario.

So this PR is merely a restructuring of how paths of echam+jsbach forcing files+namelists are constructured. I tested it in many CMIP6 historical and ssp* experiments with the awicm-1.0-recom setup.

Over time some small additions in recom were added as well. Please excuse the delay in pushing this.

Kind regards,
Chris

@mandresm
Copy link
Contributor

I need to book time for this PR. It will have a big impact in multiple research groups so it cannot be just merged. I will only have this ammount of time by the end of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants