-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefect, Dask, and Cerberus #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will deprecate the gather_inputs function in favour of a pipeline step. At the moment, you just get a deprecation warning if you try to use the function.
Rule has a new API. Instead of input patterns as a list of strings, you now provide inputs, as a list of dictionaries. These should be key/values with path and pattern as keys, later used to get the appropriate file(s) from each path. Tests are also updated to reflect the new way of loading files into the Rules. BREAKING CHANGE: Any signature constructing a Rule object will need to be changed!
This was
linked to
issues
Sep 17, 2024
Closed
siligam
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Prefect and Dask. Additionally, we include a new API for inputs in
Rule
and deprecate thegather_inputs
function.There are no tests yet. These will be implemented on a need by need basis once something breaks and we have a reproducible error.
Superceded PRs
Revelant Commits: