Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefect, Dask, and Cerberus #34

Merged
merged 22 commits into from
Sep 20, 2024
Merged

Prefect, Dask, and Cerberus #34

merged 22 commits into from
Sep 20, 2024

Conversation

pgierz
Copy link
Member

@pgierz pgierz commented Sep 17, 2024

Summary

This PR adds support for Prefect and Dask. Additionally, we include a new API for inputs in Rule and deprecate the gather_inputs function.

There are no tests yet. These will be implemented on a need by need basis once something breaks and we have a reproducible error.

Superceded PRs

Revelant Commits:

  • feat: validation for pipeline dictionary
  • fixes tests
  • feat: hooks up pipeline validator
  • feat: rules validator
  • fixes last tests for cerberus
  • fix: allowed input_source and input_type is handled by cerberus
  • proper docs for cerberus
  • fix: small mistake in gather inputs
  • fix(gather_inputs.py): deprecates the gather_inputs function
  • feat: new API for inputs in Rule
  • doc: fix too long docstring
  • feat: forgot to add step in Pipeline
  • feat: preliminary prefect support
  • test: preliminary prefect support
  • style: minor fixup to keep line length checker happy
  • prefect and dask

pgierz added 19 commits August 7, 2024 14:51
This will deprecate the gather_inputs function in favour of a pipeline step. At the moment, you just get a deprecation warning if you try to use the function.
Rule has a new API. Instead of input patterns as a list of strings, you
now provide inputs, as a list of dictionaries. These should be
key/values with path and pattern as keys, later used to get the
appropriate file(s) from each path. Tests are also updated to reflect the
new way of loading files into the Rules.

BREAKING CHANGE: Any signature constructing a Rule object will need to
be changed!
@pgierz pgierz added enhancement New feature or request backend labels Sep 17, 2024
@pgierz pgierz requested review from siligam and mandresm September 17, 2024 06:07
@pgierz pgierz added this to the Beta Release milestone Sep 17, 2024
Copy link
Contributor

@siligam siligam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@siligam siligam merged commit 587820f into main Sep 20, 2024
4 checks passed
@siligam siligam deleted the paul branch September 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema-Checking for Configuration File Time resampling Process over several years
2 participants