-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/save_dataset #72
Conversation
The failing tests look like segfaults, and should be handled when #66 is done. I would recommend merging that branch into this one and seeing if it works then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I have some questions and suggestions that you could have a look at.
I'd also like to have @mandresm read through these changes to see that he understands them as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last cleanup, see suggested changes.
Copilot SummaryThis pull request includes several important changes to the Configuration Handling Improvements:
Dataset Processing Enhancements:
Testing Workflow Updates:
These changes collectively improve the robustness and reliability of the |
Thank you for contributing! 🎉
Summary of the most important changes
Usage example in the PR
Please put a small usage example in the PR body so that we can see what you want to do.
These sorts of examples should also be in the docstrings of your code!
Checklist
validate.py
fileso that the user can see documentation for the arguments.
Copilot Summary
If you have Github Co-Pilot, please include an automatically generated summary.