Improve user interface for the dask dashboard #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he dashboard_link of the cluster and fallback to default dashboard_link
…orize into fix/dask_dashboard
|
For some reason I cannot explore right now, the tests are broken. Other than that, I think is ready to be reviewed. |
pgierz
previously approved these changes
Nov 27, 2024
pgierz
previously approved these changes
Nov 27, 2024
pgierz
approved these changes
Nov 27, 2024
|
Thanks @pgierz for the fixes!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing! 🎉
Summary of the most important changes
This pull request introduces:
cmorizermodule to use this new function.pymorize ssh-tunnelcommand that you need to run in your laptopNew module for Dask cluster management:
src/pymorize/cluster.py: Added a new module containing theset_dashboard_linkfunction to manage the Dask cluster's dashboard link, including handling errors when the cluster is not launched from JupyterHub.Integration with existing codebase:
src/pymorize/cmorizer.py: Imported theset_dashboard_linkfunction from the newclustermodule and used it in the_post_init_create_dask_clustermethod to set the dashboard link for the SLURMCluster. [1] [2] in this PR.Checklist
[ ] If I have made a new step which requires new arguments, these are added to thevalidate.pyfileso that the user can see documentation for the arguments.