Fixes #126 - STATEINTENT_INTERNAL #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new constant `ESMF_STATEINTENT_INTERNAL` of type `ESMF_StateIntent_Flag`. - Does not attempt to extend/modify built-in tests to cover the (minimal) new functionality. - Note that the internal ids for the UNSPECIFIED/INVALID cases are changed from 3/4 to 4/5 respectievly. This could in theory break user code that incorrectly relies on those values. - Fixed minor typo (missing period) in documentation.
theurich
requested changes
Feb 22, 2023
- Also added documentation for the new option.
|
ok - I've verified the latest patch builds on laptop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new constant
ESMF_STATEINTENT_INTERNALof typeESMF_StateIntent_Flag.Does not attempt to extend/modify built-in tests to cover the (minimal) new functionality.
Note that the internal ids for the UNSPECIFIED/INVALID cases are changed from 3/4 to 4/5 respectievly. This could in theory break user code that incorrectly relies on those values.
Fixed minor typo (missing period) in documentation.