Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a clear_output to remove previous backup version #335

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

safaci2000
Copy link
Contributor

Fixes #325

@safaci2000 safaci2000 added this to the 0.7.2 milestone Jan 14, 2025
@safaci2000 safaci2000 force-pushed the feature/clearBackup branch 3 times, most recently from b96ac0f to ca8e1ec Compare January 14, 2025 16:40
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes missing coverage. Please review.

Project coverage is 47.57%. Comparing base (1bb09d5) to head (71c48db).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cli/backup/dashboard.go 0.00% 4 Missing ⚠️
internal/service/dashboards.go 55.55% 4 Missing ⚠️
internal/tools/generics_tooling.go 70.00% 2 Missing and 1 partial ⚠️
internal/service/folders.go 50.00% 2 Missing ⚠️
internal/service/connection_permissions.go 0.00% 1 Missing ⚠️
internal/service/dashboard_permissions.go 0.00% 1 Missing ⚠️
internal/service/gdg_api.go 50.00% 0 Missing and 1 partial ⚠️
internal/service/login.go 66.66% 1 Missing ⚠️
internal/service/organizations.go 0.00% 1 Missing ⚠️
internal/service/user.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   47.55%   47.57%   +0.01%     
==========================================
  Files          84       85       +1     
  Lines        6635     6647      +12     
==========================================
+ Hits         3155     3162       +7     
- Misses       3113     3117       +4     
- Partials      367      368       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@safaci2000 safaci2000 self-assigned this Jan 14, 2025
@safaci2000 safaci2000 requested a review from arlake228 January 14, 2025 17:02
@safaci2000 safaci2000 merged commit 25a106c into main Jan 14, 2025
7 checks passed
@safaci2000 safaci2000 deleted the feature/clearBackup branch January 14, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dashboards moved to another folder are not deleted from storage
2 participants