Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to server process during an existing test freezes the server #202

Closed
bmah888 opened this issue Aug 27, 2014 · 0 comments
Closed
Assignees
Labels

Comments

@bmah888
Copy link
Contributor

bmah888 commented Aug 27, 2014

With an existing test running, telnet the server process's control port. The server process will hang (in a blockin read call on the control sockets) until the telnet disconnects. This obviously will disrupt the running test.

I'm testing a fix (in a part of the code that I actually noted during an earlier code review). This bug is to track the fix. Needs to go to the 3.0-STABLE branch.

@bmah888 bmah888 added this to the 3.0.x milestone Aug 27, 2014
@bmah888 bmah888 self-assigned this Aug 27, 2014
@bmah888 bmah888 added the bug label Aug 27, 2014
bmah888 added a commit that referenced this issue Aug 27, 2014
By design, an iperf3 server only runs one test at a time.  New
connections from other clients (during an existing test) are
rejected.  A problem is that the server code that rejects the test
tries (for some reason) to read the cookie from the client, even
though it's going to reject the connection anyway.

A way to break an existing test is:  With a test running, make a TCP
connection to the server's control port (this can easily be done with
a telnet client).  The server will hang in a blocking read call trying
to read the cookie from a non-existent client, while the test is
essentially frozen.

The fix is to remove the attempted read of the cookie.

Fixes #202.

(cherry picked from commit 40d45dc)
Signed-off-by: Bruce A. Mah <bmah@es.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant